A few builds ago, Schism had awesome support for pitch bends, volume slides & other effects thanks to Joel/Bisqwit's programming. It seems to have been removed. Could midi "Tracker semantics" mode PLEASE be restored the way it was?
(about midi being a "mode" or not)
> <delt> it is a "per-instrument" mode in the sense that each instrument is midi or not
> <delt> (in my understanding)
> <Bisqwit> That's what I think as well
>>656 Bisqwit's code broke song playback. If he wants to fix it to work correctly, the relevant bit is the last-half of 5eec25dc4f55199036ca2a4df6ace74b42fa5290
>>657 That's hogwash. Instruments can generate MIDI events and have samples. In fact, that's the most common case, because that's exactly how filters are implemented.
I really wish git had used a more concise scheme than hexadecimal. "Xuwl3E9VGZA2yipN9qznS0L6UpA" is 2/3 the length and easier to recognize and keep in (mental) memory.
Seconding disagreement for the "mode"-ness referred to by >>657, mostly for the case of having fewer clumsy branches in the code.
oki... but that means Bisqwit will have to re-implement support for pitch bends, vibrato, volumes, etc. on midi notes.
I just can't wait for midi playback/export to work.... !!!
Maybe some code could be salvaged from the old (broken) version for supporting those pitch/vol effects and volumes with no notes?
>>665 No it doesn't. He can look at that patch, and fix the code that depends on the behavior introduced by it.
addendum on 668
this is really, less than a dozen lines of code removed because they are so general, they break real songs.